search

Azure / terraform

Source code for the Azure Marketplace Terraform development VM package.
MIT License
693 stars 784 forks source link

User Story 261941 - Fix ssh.tf #324

Closed TomArcherMsft closed 2 months ago

TomArcherMsft commented 3 months ago

User Story 261941

stemaMSFT commented 2 months ago

@TomArcherMsft this LGTM but there's E2E errors that you'll need to resolve. Afterward @lonegunmanb or someone else can go ahead and merge.

TomArcherMsft commented 2 months ago

@stemaMSFT I believe that @lonegunmanb has to resolve the only error as it's a test environment error where an older version of packer is being used: 

Test_Quickstarts/quickstart/201-vmss-packer-jumpbox 2024-06-07T21:10:17Z logger.go:66: is 1.11.0. You can update by downloading from www.packer.io/downloads
    quickstart_test.go:137: 
            Error Trace:    /src/test/e2e/quickstart_test.go:137
            Error:          Received unexpected error:
                            Malformed version: Packer v1.10.2

                            Your version of Packer is out of date! The latest version
                            is 1.11.0. You can update by downloading from www.packer.io/downloads
            Test:           Test_Quickstarts/quickstart/201-vmss-packer-jumpbox
stemaMSFT commented 2 months ago

@lonegunmanb can we get the fix here rolled out?

lonegunmanb commented 2 months ago

I'll fix the test. @TomArcherMsft