search

Azure / trusted-signing-action

MIT License
35 stars 12 forks source link

Explore perf improvements around Install-Module #16

Closed japarson closed 2 months ago

japarson commented 4 months ago

There appears to be some known peformance issues with the Install-Module command which lead to it taking minutes to complete.

We can potentially avoid this bottleneck by using something like https://github.com/marketplace/actions/modulefast.

dlemstra commented 4 months ago

Might not be related but I was also experiencing this yesterday. That was caused by the PowerShell Gallery being slow. I took ages to load files from your module and I also had builds that took much longer or even failed due to installation issues.

Maybe keeping a copy of the whole module in this repository could be an option? Feels like a workaround but it would avoid this extra install step.

japarson commented 4 months ago

@dlemstra I like your suggestion of keeping the module in the repo (as a zip file?). I'll probably implement that at least as a workaround while I explore all the options. Another avenue to explore would be using something like https://github.com/potatoqualitee/psmodulecache/tree/main to cache the module between runs.

jetersen commented 4 months ago

FYI @japarson could be due to the C drive being slower 😢

https://github.com/actions/setup-dotnet/issues/260#issuecomment-1794326743

japarson commented 2 months ago

Slowness has mostly been resolved with caching support.