search

Azure / trusted-signing-action

MIT License
21 stars 8 forks source link

Rename code-signing-account-name option? #4

Closed dlemstra closed 2 months ago

dlemstra commented 3 months ago

It might be a good idea to rename code-signing-account-name to trusted-signing-account-name? And it also looks like the readme could use an update in the option descriptions.

sudara commented 2 months ago

In case it helps: On the public preview announcement, the team reported the reasoning for keeping the deprecated naming was to avoid breaking compatibility for the people who were on the private preview.

Perhaps some logic could be added so that both the old/new naming schemes would work?

dlemstra commented 2 months ago

Sounds like a good idea to allow both names and raise a warning when the old name is used?

japarson commented 2 months ago

Thank you for pointing this out. I tried so hard to rename everything and just completely overlooked this.

Sounds like a good idea to allow both names and raise a warning when the old name is used?

I like this idea. Would you like to open a PR? If not, I'll get to it when I have time.

dlemstra commented 2 months ago

I have created this PR: #14. When will you publish the powershell module on GitHub so we (me) can do the same there?

japarson commented 2 months ago

Closed by https://github.com/Azure/trusted-signing-action/pull/14