bug(tcgc): `getSdkHttpParameter()` doesn't handle default value

archerzz commented 3 weeks ago

Describe the bug

We try to set a endpoint parameter with default value in https://github.com/Azure/cadl-ranch/pull/598

@server(
  "{endpoint}",
  "Test server endpoint",
  {
    endpoint: string = "http://localhost:3000",
  }
)

The parameter can be fetched in TCGC, but default value is not parsed. Check the source codes of getSdkHttpParameter(), and it seems not handle default value: https://github.com/Azure/typespec-azure/blob/5c10b3e3524936610283b4044ddd01c73a22827f/packages/typespec-client-generator-core/src/http.ts#L294

Reproduction

Just try to parse the definition above.

Checklist

[X] Follow our Code of Conduct
[X] Check that this issue is about the Azure libraries for typespec. For bug in the typespec language or core libraries file it in the TypeSpec repo
[X] Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

tadelesh commented 3 weeks ago

@iscai-msft i remembered that only when the default value is happened in server endpoint that we will use it as client default value, is that right? if so, it seems we missed this in current code.

iscai-msft commented 2 weeks ago

Yep, it's only for api version and endpoint. This information is in .templateArguments though, so I don't think this is an issue. Closing. If it's still an issue can you reopen @archerzz

Azure / typespec-azure