[Bug]: Wrong `null` tagging for the type of property `userAssignedIdentities` for ManagedServiceIdentity in common types - Githubissues

Azure / typespec-azure

About TypeSpec Azure Libraries

https://azure.github.io/typespec-azure/

MIT License

11 stars 37 forks source link

[Bug]: Wrong `null` tagging for the type of property `userAssignedIdentities` for ManagedServiceIdentity in common types #1110

Closed MaryGao closed 3 months ago

MaryGao commented 3 months ago

Describe the bug

The type of property userAssignedIdentities for ManagedServiceIdentity should be Record<UserAssignedIdentity | null> but it is Record<UserAssignedIdentity> | null.

current typespec: https://github.com/Azure/typespec-azure/blob/fe90e201b7ad8bda7f98e786debfae37c025ee98/packages/typespec-azure-resource-manager/lib/common-types/managed-identity.tsp#L26C4-L27

swagger definition: https://github.com/Azure/azure-rest-api-specs/blob/87a08b955c257c773a3bd42553c718d4b1092955/specification/common-types/resource-management/v5/managedidentity.json#L15

Reproduction

see swagger definition: https://github.com/Azure/azure-rest-api-specs/blob/87a08b955c257c773a3bd42553c718d4b1092955/specification/common-types/resource-management/v5/managedidentity.json#L15

Checklist

[X] Follow our Code of Conduct
[X] Check that this issue is about the Azure libraries for typespec. For bug in the typespec language or core libraries file it in the TypeSpec repo
[X] Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.