Azure / typespec-azure

About TypeSpec Azure Libraries
https://azure.github.io/typespec-azure/
MIT License
8 stars 28 forks source link

Fix [Bug]: Wrong `null` tagging in ManagedServiceIdentity #1111

Closed MaryGao closed 2 days ago

MaryGao commented 3 days ago

fixes https://github.com/Azure/typespec-azure/issues/1110

to match with the swagger definition https://github.com/Azure/azure-rest-api-specs/blob/87a08b955c257c773a3bd42553c718d4b1092955/specification/common-types/resource-management/v5/managedidentity.json#L9-L16

azure-sdk commented 3 days ago

All changed packages have been documented.

Show changes ### `@azure-tools/typespec-azure-resource-manager` - _fix_ [✏️](https://github.com/Azure/typespec-azure/edit/fix-managed-identity-def-issue/.chronus/changes/fix-managed-identity-def-issue-2024-6-2-18-48-2.md?pr=/Azure/typespec-azure/pull/1111) > Fix the type discrepancy issue for property userAssignedIdentities in common types V5 ManagedServiceIdentity
azure-sdk commented 3 days ago

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/1111/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/1111/

timotheeguerin commented 3 days ago

Can you regenerate the new common types and add the command to the regen-samples so it’s verified in the ci