search

Azure / typespec-azure

About TypeSpec Azure Libraries
https://azure.github.io/typespec-azure/
MIT License
14 stars 40 forks source link

add resource type scalar in `typespec-azure-core` #1272

Open ArcturusZhang opened 3 months ago

ArcturusZhang commented 3 months ago

Fixes https://github.com/Azure/typespec-azure/issues/1268

azure-sdk commented 3 months ago

All changed packages have been documented.

Show changes ### `@azure-tools/typespec-azure-core` - _feature_ [✏️](https://github.com/ArcturusZhang/typespec-azure/edit/add-resource-type/.chronus/changes/add-resource-type-2024-6-31-14-6-51.md?pr=/Azure/typespec-azure/pull/1272) > Add `armResourceType` scalar, and changed some properties to be `armResourceType` instead of string ### `@azure-tools/typespec-azure-resource-manager` - _feature_ [✏️](https://github.com/ArcturusZhang/typespec-azure/edit/add-resource-type/.chronus/changes/add-resource-type-2024-6-31-14-6-51.md?pr=/Azure/typespec-azure/pull/1272) > Add `armResourceType` scalar, and changed some properties to be `armResourceType` instead of string
azure-sdk commented 3 months ago

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs
tadelesh commented 3 months ago

@allenjzhang could you help to review?

ArcturusZhang commented 3 months ago

We should go through some design discussion to approve this new type

Yeah I assume we should go through design discussions before we could merge this. What is the process of that?

timotheeguerin commented 3 months ago

We can talk about it tomorrow in dpg meeting(or later one if we can't) don't think this needs to be brought up to the Wednesday one

ArcturusZhang commented 1 month ago

@timotheeguerin any update on this?