Incorrect corresponding method param for Azure.Core.MaxPageSizeQueryParameter

jhendrixMSFT commented 7 months ago

Describe the bug

The corresponding method param for Azure.Core.MaxPageSizeQueryParameter is incorrect. It should map to an entry in sdkMethod.parameters but it appears to map back to itself.

Reproduction

Using tcgc 0.41.0-dev.42

Build https://github.com/Azure/cadl-ranch/blob/main/packages/cadl-ranch-specs/http/payload/pageable/main.tsp

In sdkMethod.operation.parameters the entry for the maxpagesize query param doesn't map back to the entry in sdkMethod.parameters.

Checklist

[X] Follow our Code of Conduct
[X] Check that this issue is about the Azure libraries for typespec. For bug in the typespec language or core libraries file it in the TypeSpec repo
[X] Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

jhendrixMSFT commented 7 months ago

After some discussion, it sounds like we might want tcgc to explose these core types?

iscai-msft commented 4 months ago

Yeah, we want to explose these, and I don't think most emitters want this parameter. If this is still an issue can you reopen @jhendrixMSFT ? Thanks!

Azure / typespec-azure