Azure / vld

Visual Leak Detector for Visual C++ 2008-2015
https://kinddragon.github.io/vld/
GNU Lesser General Public License v2.1
38 stars 22 forks source link

Installed 2.5.6 changelog contains only changes from 2.5.1 #7

Open Flamefire opened 3 years ago

Flamefire commented 3 years ago

I downloaded and installed vld-2.5.6-setup.exe from the GH releases but the installed changelog does state "Visual Leak Detector (VLD) Version 2.5.1"

Is there a bug in the setup generation?

mattdurak commented 3 years ago

I see the latest change log with my 2.5.7 install in C:\Program Files (x86)\Visual Leak Detector\CHANGES.txt

Do you still see this issue with 2.5.7? If so, I'm not sure what the issue is, but you are welcome to submit a PR if you see an issue that can be fixed and we will do our best to review and merge it.

You should also check that C:\Program Files (x86)\Visual Leak Detector\bin\Win64\vld_x64.dll has a file version of 2.5.7 (or 2.5.6 for your current install) to make sure it actually installed.

Flamefire commented 3 years ago

With 2.5.7 I can confirm this is working.

For reference: I've seen this while using a CMake Find module which reads the changes.txt to get the version as the headers don't contain the version (might be worth to add): https://github.com/Return-To-The-Roots/s25client/blob/master/cmake/Modules/FindVLD.cmake