Azure / vscode-aks-tools

Visual Studio Code extension for Azure Kubernetes Service
MIT License
42 stars 52 forks source link

Fixing freezing dockerfile create page #945

Closed ReinierCC closed 2 months ago

ReinierCC commented 2 months ago

This PR is to fix the following issue:

Screenshot 2024-09-24 at 11 15 44 AM

where the "Automated Deployments: Draft a Dockerfile" page would freeze for any user input after clicking the create button.

This occured because the draft command being executed to create the dockerfile was waiting for cli style user input about the BUILDVERSION.

Screenshot 2024-09-24 at 11 17 50 AM

Previously the builderImageTag was or'ed with an empty string. But builderImageTag was already of type string | null .

Screenshot 2024-09-24 at 11 19 46 AM Screenshot 2024-09-24 at 11 21 28 AM

By removing the empty string, the draft binary uses BUILDERTAG as null and does not request user input.

There still exists issue #944 for python dockerfiles. But the fix for that would best come from a modification to the draft binary itself.

ReinierCC commented 2 months ago

VSIX For Testing (Remove .zip from file name):

vscode-aks-tools-1.4.9-docker-create-freeze-fix.vsix.zip