Azure / webapps-deploy

Enable GitHub developers to deploy to Azure WebApps using GitHub Actions
MIT License
267 stars 193 forks source link

V3 using node.js 16 upgrade to node.js 20 seeing 16 is deprecated #392

Closed MV-PDM closed 5 months ago

MV-PDM commented 8 months ago

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: azure/webapps-deploy@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Does not take a node.js version either

runs:
  using: 'node20'
surenderssm commented 8 months ago

ACK on the need to move to NODE:20. This is in our scope, will keep the forum updated. cc : @kumaraksh1

michealmueller commented 8 months ago

i am also running into this today, do we have an ETA or hotfix/workaround or release?

or perhaps a different gh action till this is sorted?

RudiSzalai commented 8 months ago

It is hard to believe that there is this little interest in this issue. What do other people use to deploy web apps in Azure??

MV-PDM commented 8 months ago

It is hard to believe that there is this little interest in this issue. What do other people use to deploy web apps in Azure?? @RudiSzalai

No idea. the most problematic issue is that it really only requires to update the node version in the action.yml

from: runs: using: 'node16'

to: runs: using: 'node20'

jlaundry commented 7 months ago

Looks like there are 2x PRs for this: #393 and #397 (both have exactly the same 1-line change, #397 tests have run and passed)

VaclavElias commented 7 months ago

This needs to be done also for v2. Another reference https://github.com/Azure/webapps-deploy/issues/372

DThorpFF commented 7 months ago

Looks like there are 2x PRs for this: #393 and #397 (both have exactly the same 1-line change, #397 tests have run and passed)

Is there an estimated time for when this will be merged?

martincostello commented 7 months ago

GitHub Actions; All Actions will run on Node20 instead of Node16 by default

Following on from our warning in workflows using Node16 we will start enforcing the use of Node20 rather than Node16 on the 13th of May.

MV-PDM commented 7 months ago

@martincostello:

GitHub Actions; All Actions will run on Node20 instead of Node16 by default

Following on from our warning in workflows using Node16 we will start enforcing the use of Node20 rather than Node16 on the 13th of May.

@surenderssm @kumaraksh please note the above.

Piedone commented 6 months ago

Duplicate of: https://github.com/Azure/webapps-deploy/issues/372

leandromsft commented 6 months ago

I´m using v3 and result this warning

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: Azure/webapps-deploy@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

peter5000 commented 6 months ago

Is there any update on this thread? I am having the same issue as leandromsft. I changed azure/webapps-deploy@v2 to azure/webapps-deploy@v3 in my yml file, but it shows the same warning

michealmueller commented 6 months ago

i got around this issue by creating my own runner and setting it up to accept node 16 rather then node 20

danielz-nenda commented 6 months ago

Submitted a Azure support request regarding this, we'll see if that helps.

ShilpiRachna1 commented 5 months ago

This issue has been fixed for webapps_deploy@v2 and webapps_deploy@v3. I apologise for the delay.

FYI - @MV-PDM , @michealmueller , @RudiSzalai , @danielz-nenda , @peter5000 , @leandromsft , @martincostello , @Piedone , @VaclavElias , @DThorpFF , @jlaundry

Piedone commented 5 months ago

Great! Shouldn't then this issue and https://github.com/Azure/webapps-deploy/issues/372 be closed?