search

AzureAD / SCIMReferenceCode

Reference code to build a SCIM endpoint to automate provisioning
MIT License
163 stars 107 forks source link

[Enhancement] Use AttributeFilter to use newtonsoft only on the scim controllers #80

Open Tasin5541 opened 2 years ago

Tasin5541 commented 2 years ago

Current implementation of the json serialization and de serialization forces user to add newtonsoft to the controllers globally which is a problem if someone tries to integrate the scim endpoints into their application that's using the default text.json library (starting from .net core 3.1) which doesn't support DataContract. In this case adding newtonsoft globally is a big no.

We can use the ActionFilterAttribute Class to ensure the scim endpoints use newtonsoft and the other endpoints keep working as it is.

Tasin5541 commented 2 years ago

I would like to work on this if the maintainers approve

boscoMW commented 2 years ago

I would like to work on this if the maintainers approve

Please go ahead,

RohitTopkhane commented 6 months ago

Can we get solution without Extension newsoft.json

Sefriol commented 5 months ago

@RohitTopkhane Doable, but it would require whole Microsoft.SystemForCrossDomainIdentityManagement/Protocol to be modified to use System.Text.Json. There is a lot of OnInitialization / Initialized all over the place which I am unsure how meaningful they are. In addition, there is also a bunch of Json Serialization / Deserialization Factory stuff that I am not so sure about.