Duplicate log keyID for IDX10503 - Githubissues

AzureAD / azure-activedirectory-identitymodel-extensions-for-dotnet

IdentityModel extensions for .Net

MIT License

1.06k stars 401 forks source link

Duplicate log keyID for IDX10503 #2604

Open RetYn opened 5 months ago

RetYn commented 5 months ago

Summary

The log message for IDX10503 in this https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2436/files is duplicated: key.ToString already contains the key.keyId in it. https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/dev/src/Microsoft.IdentityModel.Tokens/SecurityKey.cs

In addition, I don't think it's necessary to print the InternalId which is the thumbprints of the public key in the log.

bdapoigny commented 2 weeks ago

Can i work on it ? @kellyyangsong