search

AzureAD / azure-activedirectory-identitymodel-extensions-for-dotnet

IdentityModel extensions for .Net
MIT License
1.05k stars 396 forks source link

[Feature Request] Microsoft.IdentityModel.Protocols.OpenIdConnect: Standardize Class Naming for Constants #2665

Open joegoldman2 opened 3 months ago

joegoldman2 commented 3 months ago

In Microsoft.IdentityModel.Protocols.OpenIdConnect, some classes that contain only constants are named in plural form while others are in singular form.

To maintain consistency, I propose that we standardize the naming convention for these classes. We should choose either singular or plural form for all such classes.

Affected Classes: OpenIdConnectGrantTypes, OpenIdConnectParameterNames, OpenIdConnectPrompt, OpenIdConnectResponseMode, OpenIdConnectResponseType, OpenIdConnectScope, OpenIdProviderMetadataNames.

This breaking change can be done for the new 8.x major release.

brentschmaltz commented 2 months ago

@joegoldman2 i appreciate all the great work you have been doing. Rather than break people, we could have the new class get the value from the old class. OpenIdConnectPrompts. None => OpenIdConnectPrompt.None;

It is low on my priority list.

joegoldman2 commented 2 months ago

Rather than break people, we could have the new class get the value from the old class.

Agree. In this case, the existing classes should be probably deprecated (obsolete).

I can help with the implementation if you decide what naming convention you would like to follow.