search

AzureAD / azure-activedirectory-library-for-cordova

ADAL for Cordova
59 stars 111 forks source link

Crash on IOS - CordovaAdalPlugin tokenCacheDeleteItem #170

Open khalidawwad opened 7 years ago

khalidawwad commented 7 years ago

Issue Description

Crash on IOS Source telemetery.

crashed thread log:

Thread 11 Crashed:

1 | libobjc.A.dylib | objc_object::release() + 16 2 | Flow | __42-[CordovaAdalPlugin tokenCacheDeleteItem:]_block_invoke (CordovaAdalPlugin.m:253) 3 | libdispatch.dylib | _dispatch_call_block_and_release + 20

All log - attached

Repro Environment Details

  1. Installed plugin version: Latest
  2. Target Platform: for example, Android or Windows 10 or Windows Phone 8.1 iOS
  3. Cordova and platform versions: just run cordova -v && cordova platform list 6.5.0

Installed platforms: ios 4.5.1 Available platforms: amazon-fireos ~3.6.3 (deprecated) android ~6.1.1 blackberry10 ~3.8.0 browser ~4.1.0 firefoxos ~3.6.3 osx ~4.0.1 webos ~3.7.0

  1. Test device and OS version: for example, Nexus 5 Android 6.0, Windows Mobile 10 emulator, iOS 10, 11
  2. Cant run logs - telemetry issue
khalidawwad commented 7 years ago

This maybe related: Delete cache item already called and processing, the second call crashed.

crash_2.log

khalidawwad commented 6 years ago

Local fix in our code: We wait for first item deleting completion before deleting a second item.