AzureAD / azure-activedirectory-library-for-cordova

ADAL for Cordova
59 stars 112 forks source link

ms adal cordova plugin for ionic 4 not compatible with cordova 9.0 and ios 13.2 #214

Open adeyemosamuel opened 4 years ago

adeyemosamuel commented 4 years ago

ms adal cordova plugin is currently not working with xcode simulator. Ionic 4 app hangs on splash screen on xcode simulator. Kindly upgrade ms adal cordova plugin for cordova 9.0 and ios 13.2.

adeyemosamuel commented 4 years ago

ms adal cordova plugin is currently not working with xcode simulator. Ionic 4 app hangs on splash screen on xcode simulator. Kindly upgrade ms adal cordova plugin for cordova 9.0 and ios 13.2.

Jankowski-J commented 4 years ago

Currently experiencing the same issue. Any workarounds? Fixes?

adeyemosamuel commented 4 years ago

@Jankowski-J Microsoft no longer supports MS-ADAL, you can try using Azure B2C cordova plugin or MSAL.

Jankowski-J commented 4 years ago

Thank you for your reply. I will check these out

Pozdrawiam, Jakub Jankowski


From: adeyemosamuel notifications@github.com Sent: Monday, February 24, 2020 3:25:27 PM To: AzureAD/azure-activedirectory-library-for-cordova azure-activedirectory-library-for-cordova@noreply.github.com Cc: JJankowski jankowski.jakub@outlook.com; Mention mention@noreply.github.com Subject: Re: [AzureAD/azure-activedirectory-library-for-cordova] ms adal cordova plugin for ionic 4 not compatible with cordova 9.0 and ios 13.2 (#214)

@Jankowski-Jhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJankowski-J&data=02%7C01%7C%7C91b1e3a5c23241c75e8208d7b93564fb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637181511281819701&sdata=i7aLQzWjnfvAHWypmC2gfd8fcIgtwIP2SEljwqTy%2BOQ%3D&reserved=0 Microsoft no longer supports MS-ADAL, you can try using Azure B2C cordova plugin or MSAL.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzureAD%2Fazure-activedirectory-library-for-cordova%2Fissues%2F214%3Femail_source%3Dnotifications%26email_token%3DAAQLRFGEHJIPGKAOOLVK5VTREPKFPA5CNFSM4JY5IC42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMX7CRQ%23issuecomment-590344518&data=02%7C01%7C%7C91b1e3a5c23241c75e8208d7b93564fb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637181511281829692&sdata=5C0RAKVOpE9s8%2Fz1J91DGM%2FdY1Q4OEJbzfoiyLqNg50%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAQLRFGLV6KF6FUFLROW3XLREPKFPANCNFSM4JY5IC4Q&data=02%7C01%7C%7C91b1e3a5c23241c75e8208d7b93564fb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637181511281839687&sdata=g0VriOQrm0qY7Hoq0uutdNx266Jm9kTxduLM4MR49lQ%3D&reserved=0.

lfreneda commented 4 years ago

@Jankowski-J do you have some news about it? Did you make it work somehow?

fradali commented 4 years ago

I tried Msal (angular) with ionic 5 and it's working only with navigator , the b2c is an entreprise solution for ionic ...

lfreneda commented 4 years ago

I tried Msal (angular) with ionic 5 and it's working only with navigator , the b2c is an entreprise solution for ionic ...

@fradali What do you mean by navigator? Browser?

Jankowski-J commented 4 years ago

@lfreneda we found this: https://www.npmjs.com/package/cordova-plugin-ms-adal-fork and used it in our project. Seems to work, but it will not be supported by the creator.

lfreneda commented 4 years ago

@Jankowski-J I will check it out, thanks! <3

GroupeBEL commented 4 years ago

@lfreneda yes , now I'm trying to find a solution for UiWebView. @Jankowski-J is there any fork where UiWebView is changed with WkWebView ?

Jankowski-J commented 4 years ago

I didn't search for such fork, so I don't know.


From: webteambel notifications@github.com Sent: Wednesday, April 22, 2020 2:36:07 PM To: AzureAD/azure-activedirectory-library-for-cordova azure-activedirectory-library-for-cordova@noreply.github.com Cc: JJankowski jankowski.jakub@outlook.com; Mention mention@noreply.github.com Subject: Re: [AzureAD/azure-activedirectory-library-for-cordova] ms adal cordova plugin for ionic 4 not compatible with cordova 9.0 and ios 13.2 (#214)

@lfrenedahttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flfreneda&data=02%7C01%7C%7Cced3463208dc4f8798eb08d7e6b9bb87%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637231557691447621&sdata=N6SFTIErhYeFI3hOOE%2FLvGEKzPreStQI6Hzbao%2FYaqU%3D&reserved=0 yes , now I'm trying to find a fork where UiWebView is changed with WkWebView

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzureAD%2Fazure-activedirectory-library-for-cordova%2Fissues%2F214%23issuecomment-617752384&data=02%7C01%7C%7Cced3463208dc4f8798eb08d7e6b9bb87%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637231557691457626&sdata=t24cUhDO4C9yuQOb6l6nAE3WCdYc0j7SegtPhfTGTGk%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAQLRFB5D6EW5GFL23QAXZTRN3QDPANCNFSM4JY5IC4Q&data=02%7C01%7C%7Cced3463208dc4f8798eb08d7e6b9bb87%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637231557691467637&sdata=Sjz9Rz6w9Fosw2rqr7Wah7mqSjX%2B3aMfxUuTvDX9dfw%3D&reserved=0.

Perroquiet commented 4 years ago

Hi

You can use this forked plugin included the support for Cordova 9 and fix for iOS 13: cordova plugin add cordova-plugin-ms-adal-is-back

Make sure to remove platform and start a clean slate:

cordova platform rm android ios
cordova plugin rm cordova-plugin-ms-adal
cordova plugin add cordova-plugin-ms-adal-is-back
cordova platform add android ios

I've removed the references of UIWebview by updating the ADAL framework to 4.0.7 here. So you won't receive the alert from submitting to App Store

aashish-pixere commented 3 years ago

While I am trying to integrate MS-ADAL plugin with ionic 5, I am getting below error.

UI Error : AADSTS9002325: Proof Key for Code Exchange is required for cross-origin authorization code redemption

Console Error: he request body must contain the following parameter: 'client_secret or client_assertion'

We are using below technical specifications for the ionic App.

IONIC: 5

Angular: 9

@ionic-native/ms-adal: 5.27.0

cordova-plugin-ms-adal: 0.10.2

Cordova version : 9.0.0

"msal": "^1.3.3"

image_2020_08_11T17_24_46_996Z