AzureAD / azure-activedirectory-library-for-js

The code for ADAL.js and ADAL Angular has been moved to the MSAL.js repo. Please open any issues or PRs at the link below.
https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/maintenance/adal-angular
Apache License 2.0
627 stars 374 forks source link

getResourceForEndpoint may contain a bug #753

Closed mchuck closed 6 years ago

mchuck commented 6 years ago

Isn't this code:

for (var configEndpoint in this.config.endpoints) { ....

in adal.js, line 1263 iterating over indices of array, instead of values?

EDIT:

From other examples, I see, that the endpoints property has to be an object, and everything works normally.

rohitnarula7176 commented 6 years ago

@Alaiven endpoints is an object with key-value pair. We are iterating over the keys and then extracting the value from the specific key. This is the correct way of doing it. Closing this issue. Please reopen if you still face issues.