feat(storage): ability to pass a custom storage

AzureAD / azure-activedirectory-library-for-js

The code for ADAL.js and ADAL Angular has been moved to the MSAL.js repo. Please open any issues or PRs at the link below.

https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/maintenance/adal-angular

Apache License 2.0

627 stars 374 forks source link

feat(storage): ability to pass a custom storage #775

Closed 4F2E4A2E closed 4 years ago

4F2E4A2E commented 6 years ago

Some apps in the enterprise have the requirement to encrypt all it's client data on the storage. This is a request for adal-angular to support a custom localStorage or a custom sessionStorage.

Closes https://github.com/AzureAD/azure-activedirectory-library-for-js/issues/776

msftclas commented 6 years ago

All CLA requirements met.

4F2E4A2E commented 6 years ago

@weijjia @nehaagrawal Hey guys, any feedback on this PR would be much apreciated. travis-ci is failing, but not because of this PR directly, but broken dependencies in constellation with certain node versions.

The ci must be broken in master as well, since another PR https://github.com/AzureAD/azure-activedirectory-library-for-js/pull/777 with no changes in the functionality is also failing.

Maybe the travis-ci &/ dependency problem should be adressed in another issue, are you guys on it?

Arikael commented 6 years ago

see #799 I hope we can resolve this issue fast, because PRs are piling up

4F2E4A2E commented 5 years ago

Can we get any updates on this one?

4F2E4A2E commented 4 years ago

Why has it been closed without even a short notice?