search

AzureAD / azure-activedirectory-library-for-js

The code for ADAL.js and ADAL Angular has been moved to the MSAL.js repo. Please open any issues or PRs at the link below.
https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/maintenance/adal-angular
Apache License 2.0
627 stars 372 forks source link

adalRenewFrame iFrame's borderWidth not set correctly #788

Closed dlannoye closed 6 years ago

dlannoye commented 6 years ago

It looks like this issues has been previous reported in #682 & #562, but has never been fixed in the library. The root cause is the code setting the borderWidth to "0px" isn't setting it through the element's style property so it is not respected by browsers.

In adal.js this line should be updated:

ifr.style.width = ifr.style.height = ifr.borderWidth = '0px';

to

ifr.style.width = ifr.style.height = ifr.style.borderWidth = '0px';
dlannoye commented 6 years ago

FYI, I opened PR #789 with a fix for this issue

rohitnarula7176 commented 6 years ago

@dlannoye Closing this issue. Fixed and merged in dev.