search

AzureAD / azure-activedirectory-library-for-js

The code for ADAL.js and ADAL Angular has been moved to the MSAL.js repo. Please open any issues or PRs at the link below.
https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/maintenance/adal-angular
Apache License 2.0
627 stars 374 forks source link

Fix setting of the borderWidth on adal frame #789

Closed dlannoye closed 5 years ago

dlannoye commented 6 years ago

This fixes #788, #682, & #562. The root cause was the the code was not correctly setting the borderWidth since it didn't use the style object. Because of this it failed to override default user agent styles provided by the browser causing the iframe to require space.

I also updated a ' character that was not using the proper encoding in a comment.

dlannoye commented 6 years ago

Any action of this? The CI build failure looks like an issue on your end with the configuration?

rohitnarula7176 commented 5 years ago

@dlannoye I apologize for the delayed response. Thank you for creating a PR with the fix. I was not able to merge your PR as the build was failing. Since it was a one line change, I have created a PR using the fix you provided. We will include this as part of our next release.