search

AzureAD / azure-activedirectory-library-for-js

The code for ADAL.js and ADAL Angular has been moved to the MSAL.js repo. Please open any issues or PRs at the link below.
https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/maintenance/adal-angular
Apache License 2.0
627 stars 374 forks source link

Reworking callback context #791

Closed dggsax closed 6 years ago

dggsax commented 6 years ago

The work in this pull request originates from internship project at Microsoft in which we used adal.js for a VSTS Extension. There were issues where context assumptions (primarily that window.parent === window) would prevent adal from properly handling window callbacks. Once those assumptions were rearranged, things began to work. Hoping that maintainers can see the changes I made and provide feedback on the substance of them, and if they are aware of other portions within handleWindowCallback() that they can be addressed.

dggsax commented 6 years ago

Just noticed the CI Build Failed. Will investigate.

dggsax commented 6 years ago

Closing because we are no longer using Adal with our project. Although, the issues proposed should still be investigated with future maintenance of Adal.