search

AzureAD / azure-activedirectory-library-for-js

The code for ADAL.js and ADAL Angular has been moved to the MSAL.js repo. Please open any issues or PRs at the link below.
https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/maintenance/adal-angular
Apache License 2.0
627 stars 374 forks source link

IE11/Edge - redirect issues #808

Closed kameelyan closed 5 years ago

kameelyan commented 6 years ago

In IE11/Edge, after logging in on the microsoft side, the redirect happens and the site gets stuck. The return URL looks like this: https://{baseURL}/#id_token={token}&state={state}&session_state={session_state}

My config looks like: const adalConfig = { instance: 'https://login.microsoftonline.com/', tenant: '{tenant}', clientId: '{clientID}', extraQueryParameter: 'nux=1', requireADLogin: true, endpoints: endpoint, cacheLocation: 'localStorage' // enable this for IE };

It's like the library isn't picking up the URL on return or something. Any ideas?

I swear this was working a week ago and the only thing we changed was the client ID recently, which I don't think would cause this issue.

jagan-copilot commented 6 years ago

I am dealing with the same problem, The popup window closes after login and is stuck with login page.

Versions

No issue observed in chrome browser and works as expected.

kameelyan commented 6 years ago

Update your version of adal-angular-4, I'm on 3.0.13 and it's working for me now.

Also keep these known issues in mind: https://github.com/AzureAD/azure-activedirectory-library-for-js/wiki/Known-issues-on-Edge#issues

jagan-copilot commented 5 years ago

Hello kameelyan, If you are referring to adal-angular4, it is dependent on adal-angular 1.0.15 while i was referring to the latest version 1.0.17. Wondering how adal-angular4 is solving the problem.

I am now upgrading to adal-angular4 and hoping to see positive result.

kameelyan commented 5 years ago

Yea I was only pointing out that the issues I faced were fixed when I updated to adal-angular4@3.0.13. I am still using adal-angular@1.0.15 though as that's what the library is forcing. I think we need a feature for the team to update to 1.0.17, but it could for you.

nehaagrawal commented 5 years ago

@https://github.com/benbaran/adal-angular4 is not supported by us and it's an independent library. I am on Microsoft Edge 44.17763.1.0 and I couldn't reproduce this issue. Are you saying the issue is present only in 1.0.17 only and if you downgrade to 1.0.15, it works fine?

navyasric commented 5 years ago

Closing this issue as there is no response related to the above comment and the library adal-angular4 is not supported by ADAL team.