search

AzureAD / azure-activedirectory-library-for-js

The code for ADAL.js and ADAL Angular has been moved to the MSAL.js repo. Please open any issues or PRs at the link below.
https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/maintenance/adal-angular
Apache License 2.0
627 stars 374 forks source link

Doc typos #858

Closed mbaroukh closed 4 years ago

mbaroukh commented 5 years ago

I'm submitting a...


[x] Documentation issue or request

Library Name

Library version

Library version: last

Current behavior

When following the doc, the first step is "Instantiate the AuthenticationContext" :

var authContext = new AuthenticationContext(config);

then in step 2 "Login the user", the code is

var user = authenticationContext.getCachedUser();

So "authenticationContext" instead of "authContext".

By the way, in step1, the created config has a parameter "callback" that is not in configurable options on https://github.com/AzureAD/azure-activedirectory-library-for-js/wiki/Config-authentication-context#configurable-options. Which is wrong ?

Expected behavior

jmckennon commented 4 years ago

These doc issues are now clarified and should be correct according to adal usage in the wiki.

Additionally, all current authentication work from Microsoft is delivered through the msal js library here. adal js is still supported only for security fixes. We recommend moving to msal js for any advanced feature requests and bugfixes.