AzureAD / azure-activedirectory-library-for-js

The code for ADAL.js and ADAL Angular has been moved to the MSAL.js repo. Please open any issues or PRs at the link below.
https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/maintenance/adal-angular
Apache License 2.0
627 stars 374 forks source link

Misleading CDN reference in documentation #862

Closed rafspiny closed 5 years ago

rafspiny commented 5 years ago

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[X] Documentation issue or request
[ ] Other... Please describe:

Browser:

Library Name

Library version

Library version: 1.0.17

Current behavior

The documentation section Install with reference to the CDN sub-section state the following:

Via CDN:

<!-- Latest compiled and minified JavaScript -->
<script src="https://secure.aadcdn.microsoftonline-p.com/lib/1.0.18/js/adal.min.js"></script>
<script src="https://secure.aadcdn.microsoftonline-p.com/lib/1.0.18/js/adal-angular.min.js"></script>

But the latest release to today is 1.0.17 and trying to curl the URL specified in the above section I got a 404.

curl 'https://secure.aadcdn.microsoftonline-p.com/lib/1.0.18/js/adal.min.js'

<?xml version="1.0" encoding="utf-8"?><Error><Code>BlobNotFound</Code><Message>The specified blob does not exist.
RequestId:05f6644d-901e-00b1-0e39-f4636c000000
Time:2019-04-16T09:49:48.0961394Z</Message></Error>

Expected behavior

To have the correct link in the documentation to help users to actually use the library.

Minimal reproduction of the problem with instructions

curl 'https://secure.aadcdn.microsoftonline-p.com/lib/1.0.18/js/adal.min.js'