Fixing incorrectly placed delimiter

[rahul-microsoft]

Problem:

• Adal 1.0.17 supports saving items with delimiter in Local Storage e.g: adal.nonce.idtoken 585bf368-cbb1-4619-8e40-3feeff59ecbd||9832338-cbb1-4619-8e40-3feeff59ecbd
• Teams Web client uses ADAL 1.0.9 where items are stored without delimiter e.g: adal.nonce.idtoken 585bf368-cbb1-4619-8e40-3feeff59ecbd
• Teams N* experience uses 1.0.17. But in case user has Teams web client open in different tab, same local storage will be used.
• 1.0.17 does not check whether local storage contains value and appends new value to old value and then delimiter adal.nonce.idtoken 585bf368-cbb1-4619-8e40-3feeff59ecbd9832338-cbb1-4619-8e40-3feeff59ecbd||
• During login, matchNonce function will fail as value will be incorrect on split by delimiter, and user will not be created. This fails Teams N* scenarios.
• Hence fix is to save old value + delimiter + new value for ADAL 1.0.17 and 1.0.9 teams clients to work together

Testing:

• Can be verified with two sample apps, one with 1.0.17 and another with 1.0.9 and reusing adal.nonce.idtoken from Local storage cache.

[jasonnutter]

@rahul-microsoft Can you please provide a description (and reproduction steps) of the bug, and explanation of the fix? Thanks!