search

AzureAD / azure-activedirectory-library-for-objc

The ADAL SDK for Objective C gives you the ability to add support for Work Accounts to your iOS and macOS applications with just a few lines of additional code. This SDK gives your application the full functionality of Microsoft Azure AD, including industry standard protocol support for OAuth2, Web API integration with user level consent, and two factor authentication support.
MIT License
178 stars 113 forks source link

Allow clients to set a custom UserAgent for the HTTP(S) requests #960

Closed clausjoergensen closed 7 years ago

clausjoergensen commented 7 years ago

To allow customers to enable/disable specific functionality, such as Windows Integrated Auth (WIA), we would like ADAL to allow the clients using the library to be allowed to specify a custom UserAgent, so customers can disable explicit functionality for Mac clients.

ADAL on Mac today uses the standard Safari UserAgent, which prevents customers from disabling certainly functionality (such as WIA) for clients using ADAL without also breaking Safari.

Ideally ADAL would take a UserAgent from the client, and use it for all subsequent HTTP(S) requests as necessary.

brandwe commented 7 years ago

Assigning to @partnerinflight for triage.

partnerinflight commented 7 years ago

WIA is not currently supported by the Objc-C libraries. Making a change like the one proposed for one platform but not another doesn't make a whole lot of sense. Rejecting this enhancement request for now; please reactivate/escalate if the change can be supported with strong customer need.