search

AzureAD / azure-activedirectory-library-for-python

ADAL for Python
http://adal-python.readthedocs.io
Other
259 stars 94 forks source link

Enable dynamic whitelisting of dSTS endpoints to support new buildouts #215

Closed jmstimso closed 4 years ago

jmstimso commented 5 years ago

Enable dynamic whitelisting of dSTS endpoints to support new buildouts of national cloud environments.

UPDATED info quoted from PR conversation:

The new authority.py implementation for dSTS is to support (future) new cloud environments in which we will not be allowed to explicitly whitelist endpoints in public GitHub repos due to customer restrictions on releasing DNS names. Since I have removed dSTS whitelisting constants, these test cases should be sufficient to cover all current and future dSTS endpoints that fit the .dsts. DNS address pattern.

jmstimso commented 4 years ago

Quick question. Does dSTS accept resource parameter rather than scope parameter in the wire protocol? Is that the only reason that dSTS would stick with ADAL library, rather than picking up MSAL? Also a specific comment below.

I am not sure about the details on this, we could have a conversation with Abhinav the dSTS lead to add dSTS support to MSAL. For now, this is a short term fix to support customers already using ADAL who need to deploy a new cloud environment.