AzureAD / microsoft-authentication-library-common-for-android

Common code used by both the Active Directory Authentication Library (ADAL) and the Microsoft Authentication Library (MSAL)
MIT License
41 stars 35 forks source link

Capture broker_operation_name on MSAL_PerformIpcStrategy span #2178

Closed p3dr0rv closed 1 year ago

p3dr0rv commented 1 year ago

Why

We have multiple entries of this error: "Attempt to invoke virtual method 'boolean com.microsoft.identity.broker4j.workplacejoin.data.WorkplaceJoinData.isSharedDevice()' on a null object reference"

android_spans | where PipelineInfo_IngestionTime between (ago(7d) .. now()) | where error_message == "Attempt to invoke virtual method 'boolean com.microsoft.identity.broker4j.workplacejoin.data.WorkplaceJoinData.isSharedDevice()' on a null object reference" | where broker_version == "11.2.1"

to identify the operation that is failing we start capturing the broker_operation_name

Note: In addition we also add 2 const used int this PR