AzureAD / microsoft-authentication-library-common-for-android

Common code used by both the Active Directory Authentication Library (ADAL) and the Microsoft Authentication Library (MSAL)
MIT License
41 stars 35 forks source link

Fix crash during onCreate() #2202

Closed sansrivastav closed 1 year ago

sansrivastav commented 1 year ago

AB#2690156

LTW reported following crashes and this PR addresses the first 2 crashes:

Stack Trace 1. Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'android.os.Parcelable android.os.Bundle.getParcelable(java.lang.String)' on a null object reference at com.microsoft.identity.common.internal.broker.InstallCertActivityLauncher.onCreate(InstallCertActivityLauncher.java:16)

2. Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'android.os.Parcelable android.os.Bundle.getParcelable(java.lang.String)' on a null object reference at com.microsoft.identity.common.internal.broker.BrokerActivity.onCreate(BrokerActivity.java:16)

3. Caused by: java.lang.IllegalStateException: Unexpected fragment type at com.microsoft.identity.common.internal.providers.oauth2.CurrentTaskAuthorizationActivity.onCreate(CurrentTaskAuthorizationActivity.java:142)

See this bug for additional details: https://identitydivision.visualstudio.com/Engineering/_workitems/edit/2690156

shahzaibj commented 1 year ago

AB#2690156

Please add a proper description. PR descriptions should include a summary of What, Why, and How i.e. what the PR wants to accomplish, why the change is needed, and small summary of the changes made to accomplish the task.

sansrivastav commented 1 year ago

Only Linux broker tests on consumers pipeline is failing

image

tanmaymanolkar1 commented 1 year ago

have mentioned @sansrivastav to add the skip consumer check label, since this is a known issue and the only tests which are failing are for Linux. https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1191967&view=results image