search

AzureAD / microsoft-authentication-library-common-for-android

Common code used by both the Active Directory Authentication Library (ADAL) and the Microsoft Authentication Library (MSAL)
MIT License
41 stars 35 forks source link

Rename "is QR + PIN available" API to "get preferred auth method". #2288

Closed p3dr0rv closed 8 months ago

p3dr0rv commented 9 months ago

After a discussion with the IOs team and OneAuth team we decided to change:

  1. The API to return a more general PreferredAuthMethod enum rather than QRPINAvailability. This is to attempt to be extensible in case some other similar method is created as part of current discussions, such as NFC.
  2. The admin config will reflect this - we'd ask for "preferred_auth_config= QRPIN" rather than "qrPinAvailability = true".
p3dr0rv commented 8 months ago

Tested with Authenticator and MSAL test app in this pipeline Artifacts: https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1259288&view=results test plan: https://identitydivision.visualstudio.com/Engineering/_testPlans/define?planId=2827166&opId=1986&suiteId=2827225

iamgusain commented 8 months ago

After a discussion with the IOs team and OneAuth team we decided to change:

  1. The API to return a more general PreferredAuthMethod enum rather than QRPINAvailability. This is to attempt to be extensible in case some other similar method is created as part of current discussions, such as NFC.
  2. The admin config will reflect this - we'd ask for "preferred_auth_config= QRPIN" rather than "qrPinAvailability = true".

should it return a list of allowed AuthMethod in some order of preference determined by Admin?