search

AzureAD / microsoft-authentication-library-common-for-android

Common code used by both the Active Directory Authentication Library (ADAL) and the Microsoft Authentication Library (MSAL)
MIT License
41 stars 35 forks source link

Revert changes made to method signature for futures #2309

Closed fadidurah closed 8 months ago

fadidurah commented 8 months ago

Revert changes made to method signature to return back a ResultFuture instead of a Future. It seems to have introduced a breaking change in MSAL, instead of debugging this during release time, I rolled back part of the solution for the original google crash. In this PR i'm rolling back the whole fix for better tracking, will have a following PR to reintroduce the smaller fix into common to address the issue without adjusting method signatures that could affect msal or broker.

Original PR https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/2305

rpdome commented 8 months ago

I would suggest having 2 separate PRs - one with a full revert, and another with the change you want to keep.

This will help us to easier keep track of the change (will be helpful if something goes wrong down the line)