AzureAD / microsoft-authentication-library-common-for-android

Common code used by both the Active Directory Authentication Library (ADAL) and the Microsoft Authentication Library (MSAL)
MIT License
41 stars 35 forks source link

Reverting the skipping of strongbox for android 14 #2366

Open somalaya opened 7 months ago

somalaya commented 7 months ago

What : Reverting changes made in these PRs https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/2158 and https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/2053

Why : Changes made in PRs mentioned above are for addressing a key store error happening on Android 14. We were skipping using strongbox when -1000 error was thrown. This error was being thrown all the time on Android 14. I created a bug on google 6 months back and they finally sent an update to check if it is fixed :)

Testing : Reverted the changes made previously and tested on Android 14 device. Triggered AT POP flow from MsalTestApp and it succeeded. In the logs, I can see that key pair generation was successful and it was using strongbx.

NOTE : not merging this until end of May for the change to propogate to all OEMs