AzureAD / microsoft-authentication-library-common-for-android

Common code used by both the Active Directory Authentication Library (ADAL) and the Microsoft Authentication Library (MSAL)
MIT License
41 stars 35 forks source link

Return exception from first controller in SilentTokenCommand in case all controllers throw exceptions. #2377

Closed iamgusain closed 6 months ago

iamgusain commented 6 months ago

Returning exception from first controller in SilentTokenCommand in case all controllers throw exceptions. This is to ensure that for cases where both Broker and Msal Local controller fail, we return the error from Broker Controller (which is the first controller), so that client tries to handle/recover from the error on broker side.

somalaya commented 6 months ago

Is SilentTokenCommand the only place where this fix needs to be made? Are there any other token commands that need this fix?

iamgusain commented 6 months ago

Is SilentTokenCommand the only place where this fix needs to be made? Are there any other token commands that need this fix?

Checked offline with Sowmya, we dont need to make this specific change in other token commands/places