Extract the mock api url from code to pipeline argument

AzureAD / microsoft-authentication-library-common-for-android

Common code used by both the Active Directory Authentication Library (ADAL) and the Microsoft Authentication Library (MSAL)

MIT License

41 stars 35 forks source link

Extract the mock api url from code to pipeline argument #2387

Closed Yuki-YuXin closed 5 months ago

Yuki-YuXin commented 6 months ago

Summary

The Mock API domain is hardcoded in our test source files. This domain should not be publicly known. Please refer to https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/2387 for comments related with the PR.

Company MSAL PR: https://github.com/AzureAD/microsoft-authentication-library-for-android/pull/2103

Yuki-YuXin commented 5 months ago

@shahzaibj @p3dr0rv @fadidurah This PR makes change on pipeline yml files. Could I kindly ask for your confirmation and review in case I missed something that could cause issues to the pipeline. For the skiped MSAL consumers check, I will add -PmockApiUrl=$(MOCK_API_URL) later in msal repo. Many thanks!