search

AzureAD / microsoft-authentication-library-common-for-android

Common code used by both the Active Directory Authentication Library (ADAL) and the Microsoft Authentication Library (MSAL)
MIT License
41 stars 35 forks source link

Extract the mock api url from code to pipeline env #2388

Closed Yuki-YuXin closed 5 months ago

Yuki-YuXin commented 6 months ago

Summary:

Please go to the PR for further workhttps://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/2387 This PR is closed because of the messy state during test.

SammyO commented 5 months ago

@Yuki-YuXin I'd like to see this PR in action, i.e. run the tests using the new env var. Could you take a look at that?

SammyO commented 5 months ago

@Yuki-YuXin there are more instances of the mock API URL in the code base, that haven't been replaced as part of this PR. Some of them might be in MSAL. Could you take a look at that?

Yuki-YuXin commented 5 months ago

Summarize the discussion with Silviu in terms of this work item:

IOS don’t run the tests in the yml file. They run them locally, have a stash that we apply and then discard. As in they don’t run as part of the pipeline. They have different suite for unit which run in the pipeline and integration with mock api which run only locally.

SammyO commented 5 months ago

Summarize the discussion with Silviu in terms of this work item:

IOS don’t run the tests in the yml file. They run them locally, have a stash that we apply and then discard. As in they don’t run as part of the pipeline. They have different suite for unit which run in the pipeline and integration with mock api which run only locally.

What's your point here @Yuki-YuXin ?

Yuki-YuXin commented 5 months ago

Summarize the discussion with Silviu in terms of this work item: IOS don’t run the tests in the yml file. They run them locally, have a stash that we apply and then discard. As in they don’t run as part of the pipeline. They have different suite for unit which run in the pipeline and integration with mock api which run only locally.

What's your point here @Yuki-YuXin ?

They don't seem to intend to integrate the mock api into the pipeline in the center server and they can easily accept the changes of mock api because every time they use the url locally.

Yuki-YuXin commented 5 months ago

@Yuki-YuXin I'd like to see this PR in action, i.e. run the tests using the new env var. Could you take a look at that?

From the experience of cert PR, if we can pass the PR pipeline verification check, we prove that the new env var actually work