Review our log statements and reduce to only those that are relevant and useful. Especially the logMethodCall should be much reduced. Not every method call is relevant to know about when debugging.
Double check that the existing logs use string interpolation correctly to avoid leaking sensitive information in the logs.
Changes summary:
Every log item has correlation argument. (make sure use getCorrelationId() )
The NativeAuthMsalController.kt layer acts as the main log layer. Instead, remove logSessions under OAuth2Configuration, OAuth2Strategy, RequestProvider since the users care more about the outcome of the request than the construction and sending of the request. Apply the rule "only logger unknown error" to NativeAuthMsalController.
Remove // TODO
Add request and result Logger.infoWithObject in interactors.
infoWithObject(final String tag, final String correlationID, final String message, final ILoggable object) like warnWithObject
Goal:
Changes summary:
Company PR:
Previous comments for reference: https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/2374 msal: https://github.com/AzureAD/microsoft-authentication-library-for-android/pull/2071