search

AzureAD / microsoft-authentication-library-common-for-android

Common code used by both the Active Directory Authentication Library (ADAL) and the Microsoft Authentication Library (MSAL)
MIT License
41 stars 36 forks source link

Classifying more UNKNOWN_ERRORs #2460

Closed melissaahn closed 4 months ago

melissaahn commented 4 months ago

Summary

The error code UNKNOWN_ERROR appears frequently in our telemetry. We have a large amount of client exceptions going through the clientExceptionFromException method with an UNKNOWN_ERROR code, and there are also many places where ClientExceptions are being explicitly created with the code. After looking at the telemetry and doing some code searches in our codebase, I added some more specific error codes which will be used in the common and broker libraries. Any suggestions on name changes are welcomed.

Related PRs

melissaahn commented 4 months ago

I've tagged this PR with "skip-consumers-check" because there is one MSAL unit test which is expected to fail. See this PR: https://github.com/AzureAD/microsoft-authentication-library-for-android/pull/2147