search

AzureAD / microsoft-authentication-library-common-for-android

Common code used by both the Active Directory Authentication Library (ADAL) and the Microsoft Authentication Library (MSAL)
MIT License
41 stars 36 forks source link

Allow OneAuth to set Max MSAL-Broker Protocol version #2490

Closed rpdome closed 3 months ago

rpdome commented 3 months ago

Previously, we've always bumped the max protocol version on the MSAL/OneAuth side by default. (= declaring that OneAuth is aware and supports whatever change introduced by that protocol version in broker)

OneAuth should verify first that its code is compatible with the new protocol version before bumping it on their side.

mohitc1 commented 3 months ago 
String hello(final @NonNull IIpcStrategy strategy,

Can't OneAuth this overload of hello to pass clientMaxProtocolVersion?

Refers to: common/src/main/java/com/microsoft/identity/common/internal/controllers/BrokerMsalController.java:246 in 6dc6c7e. [](commit_id = 6dc6c7e4f3c17062eaf7cf0c5a1409510d77d6ae, deletion_comment = False)

mohitc1 commented 3 months ago

Left comment around existing hello method. This change looks fine, though.

rpdome commented 3 months ago 
String hello(final @NonNull IIpcStrategy strategy,

Can't OneAuth this overload of hello to pass clientMaxProtocolVersion?

Refers to: common/src/main/java/com/microsoft/identity/common/internal/controllers/BrokerMsalController.java:246 in 6dc6c7e. [](commit_id = 6dc6c7e, deletion_comment = False)

Hello() is invoked as part of other operations.

Do you mean they should inherit this class and override the method?

They can do that, but I think the change in this PR is cleaner.