search

AzureAD / microsoft-authentication-library-common-for-android

Common code used by both the Active Directory Authentication Library (ADAL) and the Microsoft Authentication Library (MSAL)
MIT License
41 stars 36 forks source link

Check inbox code validity in Native Auth E2E tests, Fixes AB#3037823 #2509

Closed rmccahill closed 2 weeks ago

rmccahill commented 2 months ago

This PR updates the logic for retrieving a code from the test inbox - the code retrieved will be checked in the calling test to ensure that the retrieved code is valid, since we occasionally get expired codes from the inbox. If a code is invalid, the test is retried, filtering out the emails previously retrieved to ensure we're getting the latest email. If we don't get a valid code after 3 tries, an IllegalStateException will be thrown. The E2E tests will use this new function in this PR: https://github.com/AzureAD/microsoft-authentication-library-for-android/compare/robert/retry-submit-code-e2e-tests

Work Item: AB#3037823

github-actions[bot] commented 2 months ago

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

github-actions[bot] commented 2 months ago

✅ Work item link check complete. Description contains link AB#3037823 to an Azure Boards work item.

nilo-ms commented 2 weeks ago

Closing this PR because substituted from https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/2527