search

AzureAD / microsoft-authentication-library-common-for-android

Common code used by both the Active Directory Authentication Library (ADAL) and the Microsoft Authentication Library (MSAL)
MIT License
41 stars 35 forks source link

Handle error gracefully when app url scheme is not found #2515

Open denniskniep opened 3 weeks ago

denniskniep commented 3 weeks ago

Can we add an error handler to the AmazonAppUri processing? So that if someone does not have the app yet installed it is not crashing the authentication process? Then an hint can be displayed, that the app should be installed.

cc: @shahzaibj

denniskniep commented 3 weeks ago

@microsoft-github-policy-service agree

shahzaibj commented 2 weeks ago

@denniskniep I'm not sure what a hint could be for installing the app. Is the app on PlayStore and/or is there a URL for downloading this app?

denniskniep commented 2 weeks ago

Then an hint can be displayed, that the app should be installed.

@shahzaibj What I meant with that was: Currently the authentication process crashes entirely, which means the actual website is not visible anymore to the user, therefore the authentication process can not render any guidance to the user to resolve that issue. A potential guidance from the authentication process could be a hint, that the user should install an app.

But that is nothing I see in that library here. It must be implemented by the individual authentication process. However, to enable this, it would be good to catch that error.

denniskniep commented 2 weeks ago

@shahzaibj implemented your suggestions

denniskniep commented 6 days ago

Hi @shahzaibj, can you propose someone who can be the second reviewer?