AzureAD / microsoft-authentication-library-common-for-objc

Common code used by both the Active Directory Authentication Library (ADAL) and the Microsoft Authentication Library (MSAL)
MIT License
33 stars 36 forks source link

Add new account type to handle On-prem ADFS scenarios #1397

Closed SunandaChowdhary closed 4 months ago

SunandaChowdhary commented 4 months ago

Proposed changes

Update MSIDAccountType enum to include "ADFS" as new account type. Correspondingly update implementation as well

Describe what this PR is trying to do. When ADFS account type is presented to Identity Core then it is defaulted to type "Other" causing ADFS on prem flow to fail for Outlook macOS. Hence added "adfs" account type.

Type of change

Risk

Migration of existing ADFS accounts will not work. This is expected by OneAuth-MSAL.

Additional information

Tested these changes locally along with Outlook mac and OneAuth-MSAL code and end to end flow works as expected.

SunandaChowdhary commented 4 months ago

Merged directly to hotfix branch