Adding network error check

fidelianawar commented 1 month ago

Proposed changes

Currently, SSO extension returns a network error but we prompt for interaction required. When MSAL doesn't have RT, it returns that interaction required instead of network unavailable in this case. ADO item

In addition if there is a network error, we do not want to continue to fallback controllers of broker or local controller. Therefore this change adds a check before returning to fallback controller if there is a no network error.

Type of change

[ ] Feature work
[X] Bug fix
[ ] Documentation
[ ] Engineering change
[ ] Test
[ ] Logging/Telemetry

Risk

[ ] High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
[ ] Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
[X] Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

hieunguyenmsft commented 1 month ago

I added a flakiness UTs fix, seems like the failure tests are gone, please carry the fix when merging this PR to dev if no concern. thank you!

juan-arias commented 1 month ago

@fidelianawar @hieunguyenmsft, merge from dev to fix the pipeline [MSAL] Common core submodule update check error (Vision Framework Failed)

kaisong1990 commented 1 month ago

@fidelianawar Change looks good, can you please also create a manual test case for this release? Thanks!

AzureAD / microsoft-authentication-library-common-for-objc