[Bug] MSAL .NET versions < 4.5.0 do not support system browser on iOS 13

mtanml commented 4 years ago

Edit to original post

If you are using the system browser with iOS 13, please update to MSAL.NET 4.5.0, which uses the required presentation context when authenticating on system browser with iOS 13.

If you are not using 4.5.0+, you will run into the issue listed below:

Starting with iOS 13, when authenticating using the system browser, MSAL .NET is required to provide a presentation context when using ASWebAuthenticationSession. Apple added multi-window support, and therefore they need to specifically know where to present the context (this is a breaking change).

In iOS 12, the AuthenticationSession API was iOS only and apps drew into a single window. However, now, with iPadiOS and macOS support, MSAL .NET will need to give the session a presentationContextProvider, and that presentationContextProvider will provide a window via the PresentationAnchor method.

Customer impact

Your app is impacted if all of the below are true:

You have a Xamarin iOS App, and
You are targeting iOS 13+, and
You use system browser (default in MSAL .NET) for interactive authentication
You are using a version lower then 4.5.0 of MSAL .NET

Workaround

Update to MSAL.NET 4.5.0, or higher, which includes the necessary fixes for handling the presentation context on iOS 13.

Or,

Use the embedded webview. Please see the documentation on enabling the embedded webview on Xamarin iOS

Example:

AuthenticationResult authResult;
authResult = app.AcquireTokenInteractively(scopes)
                .WithUseEmbeddedWebView(true)
                .ExecuteAsync();

Notable Concerns Regarding the Workaround to Use the Embedded Webview

Caution when targeting B2C using embedded webview and Google auth
Loss of SSO The great benefit of the system browser, and the reason why it is used by default in MSAL .NET, is the sharing of the SSO state with other applications and with web applications without needing a broker. More information provided here on SSO and the system browser

========

Original Post

Which Version of MSAL are you using ? MSAL 4.4.0 (also occurs in 4.3.1)

Platform Xamarin iOS

What authentication flow has the issue?

Desktop / Mobile
- [X ] Interactive
- [ ] Integrated Windows Auth
- [ ] Username Password
- [ ] Device code flow (browserless)
Web App
- [ ] Authorization code
- [ ] OBO
Web API
- [ ] OBO

Other? - please describe;

Is this a new or existing app? The app is in production, and works fine on physical iOS devices (on both iOS 12.x and 13.0). I have upgraded my iPhone emulator to iOS 13, and that is where the issue occurs. Everything still works fine in iOS 12.2 on the emulator.

Repro

                    AuthenticationResult ar = await App.PCA.AcquireTokenInteractive(App.Scopes)
                        .WithAccount(Utils.GetAccountByPolicy(accounts, App.PolicySignUpSignIn))
                        .WithParentActivityOrWindow(App.ParentActivityOrWindow)
                        .ExecuteAsync();

Expected behavior Authentication process initiates

Actual behavior Immediately returns "authentication_canceled"

Possible Solution

Additional context/ Logs / Screenshots

andresbj16 commented 4 years ago

I receive the same error, initially I thought it was for the version of the nuget package but even updating it to version 4.4.0 of MSAL the same error still occurs

zachgreencbt commented 4 years ago

I updated to Xcode 11/iOS 13 last night, and my code is now also returning this error. Was working fine prior to the upgrade.

rulasg commented 4 years ago

We are having the same issue. Since Xcode update to 11 with iOS 13, now code that works on iOS 12 Emulator return authentication_canceled exception. Repro with Microsoft.Identity.client 4.3.1 and 4.4

jmprieur commented 4 years ago

@zachgreencbt @rulasg @andresbj16 @mtanml : does the iOS emulator have the latest version of Microsoft Authenticator?

jmprieur commented 4 years ago

Also adding the Supportability tab as we'd want better error messages if possible than authentication_canceled.

lperezj commented 4 years ago

Mee too. I have the same problem. I update XCode and with the new simulator with IOS 13, not working. I update MSAL from 4.3.x to 4.4.0 and the problem is the same.

jmprieur commented 4 years ago

@lperezj : does the new simulator have the latest Authenticator app?

uarcho commented 4 years ago

Same here, getting the authentication_cancelled error in simulator, still have to test on a phisical device

lperezj commented 4 years ago

@lperezj : does the new simulator have the latest Authenticator app?

I'm testing with IOS 13 simulator. If i test with IOS 12.2 simulator working fine.

jennyf19 commented 4 years ago

@jmprieur i don't believe this is related to the iOS broker, looks like an issue with the iOS 13 simulator, as @lperezj points out. Will investigate.

jmprieur commented 4 years ago

@jennyf19 : and it seems at at least some of the affected apps are B2C apps: @andresbj16, @zachgreencbt @rulasg @lperezj @uarcho are you building b2C apps?

rulasg commented 4 years ago

On our case, same project as @lperezj, we are using a corp app using corporative AAD Tenant.

mtanml commented 4 years ago

My app is B2C

jmprieur commented 4 years ago

Thanks for confirming that both cases are impacted, @rulasg and @mtanml

zachgreencbt commented 4 years ago

If it helps, this sample from Microsoft has the same problem, https://github.com/Azure-Samples/active-directory-xamarin-native-v2

jmprieur commented 4 years ago

yes, @zachgreencbt, I've noticed your issue there: https://github.com/Azure-Samples/active-directory-xamarin-native-v2/issues/84, and other confirmations

mandel-macaque commented 4 years ago

Hello,

Can you please provide the full information of your xamarin.iOS installation, would be good to know if this is happening with a package that support xcode11 or with an older one.

The easiest way to get exact version information:

On Visual Studio for Mac: "Visual Studio" menu, "About Visual Studio" item, "Show Details" button.
On Visual Studio for Windows: "Help menu", "About Microsoft Visual Studio" item.

Then copy/paste the version information (you can use the "Copy Information" button).

The Xcode version information will also be helpful since we have had several releases from Apple. (GM, GM2 or Xcode11 final).

jennyf19 commented 4 years ago

@mtanml @andresbj16 @zachgreencbt @rulasg (see above ^) Thanks @mandel-macaque

mtanml commented 4 years ago

Hello,

Can you please provide the full information of your xamarin.iOS installation, would be good to know if this is happening with a package that support xcode11 or with an older one.

The easiest way to get exact version information:

On Visual Studio for Mac: "Visual Studio" menu, "About Visual Studio" item, "Show Details" button.

On Visual Studio for Windows: "Help menu", "About Microsoft Visual Studio" item.

Then copy/paste the version information (you can use the "Copy Information" button).

The Xcode version information will also be helpful since we have had several releases from Apple. (GM, GM2 or Xcode11 final).

Microsoft Visual Studio Professional 2019 Version 16.3.0 VisualStudio.16.Release/16.3.0+29318.209 Microsoft .NET Framework Version 4.8.03761

Installed Version: Professional

ADL Tools Service Provider 1.0 This package contains services used by Data Lake tools

ASP.NET and Web Tools 2019 16.3.282.33872 ASP.NET and Web Tools 2019

ASP.NET Web Frameworks and Tools 2019 16.3.282.33872 For additional information, visit https://www.asp.net/

Azure App Service Tools v3.0.0 16.3.282.33872 Azure App Service Tools v3.0.0

Azure Data Lake Node 1.0 This package contains the Data Lake integration nodes for Server Explorer.

Azure Data Lake Tools for Visual Studio 2.4.1000.0 Microsoft Azure Data Lake Tools for Visual Studio

Azure Functions and Web Jobs Tools 16.3.282.33872 Azure Functions and Web Jobs Tools

Azure Stream Analytics Tools for Visual Studio 2.4.1000.0 Microsoft Azure Stream Analytics Tools for Visual Studio

C# Tools 3.3.1-beta3-19461-02+2fd12c210e22f7d6245805c60340f6a34af6875b C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Common Azure Tools 1.10 Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

Extensibility Message Bus 1.2.0 (d16-2@8b56e20) Provides common messaging-based MEF services for loosely coupled Visual Studio extension components communication and integration.

Fabric.DiagnosticEvents 1.0 Fabric Diagnostic Events

IntelliCode Extension 1.0 IntelliCode Visual Studio Extension Detailed Info

Microsoft Azure HDInsight Azure Node 2.4.1000.0 HDInsight Node under Azure Node

Microsoft Azure Hive Query Language Service 2.4.1000.0 Language service for Hive query

Microsoft Azure Service Fabric Tools for Visual Studio 16.0 Microsoft Azure Service Fabric Tools for Visual Studio

Microsoft Azure Stream Analytics Language Service 2.4.1000.0 Language service for Azure Stream Analytics

Microsoft Azure Stream Analytics Node 1.0 Azure Stream Analytics Node under Azure Node

Microsoft Azure Tools 2.9 Microsoft Azure Tools for Microsoft Visual Studio 0x10 - v2.9.20816.1

Microsoft Continuous Delivery Tools for Visual Studio 0.4 Simplifying the configuration of Azure DevOps pipelines from within the Visual Studio IDE.

Microsoft JVM Debugger 1.0 Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines

Microsoft Library Manager 2.0.83+gbc8a4b23ec Install client-side libraries easily to any web project

Microsoft MI-Based Debugger 1.0 Provides support for connecting Visual Studio to MI compatible debuggers

Microsoft Visual Studio Tools for Containers 1.1 Develop, run, validate your ASP.NET Core applications in the target environment. F5 your application directly into a container with debugging, or CTRL + F5 to edit & refresh your app without having to rebuild the container.

Mono Debugging for Visual Studio 16.3.7 (9d260c5) Support for debugging Mono processes with Visual Studio.

NuGet Package Manager 5.3.0 NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/

ProjectServicesPackage Extension 1.0 ProjectServicesPackage Visual Studio Extension Detailed Info

Redgate SQL Change Automation 4.0.19255.10541 Extend DevOps processes to your SQL Server databases and safely automate database deployments.

Visit https://www.red-gate.com/sca/productpage for more information.

This software contains components from Component Owl. SQL Server is a registered trademark of Microsoft Corporation. Visual Studio is a registered trademark of Microsoft Corporation.

SQL Change Automation contains code from the following open source software:

NuGet https://www.nuget.org/ SQL LocalDB Wrapper https://github.com/martincostello/sqllocaldb Autofac https://autofac.org/ Json.NET https://json.net/ MahApps.Metro http://mahapps.com/ SemVer https://github.com/maxhauser/semver Log4Net http://logging.apache.org/log4net/ StringTemplate https://github.com/antlr/stringtemplate4 Extended WPF Toolkit https://wpftoolkit.codeplex.com/ Code InfoBox VSX http://www.codeproject.com/Articles/55196/Code-InfoBox-Visual-Studio-Extension-VSX OctoPack https://github.com/OctopusDeploy/OctoPack SQLite https://sqlite.org/

This product contains icons from http://www.visualpharm.com distributed under a free backlink license.

For license details or other notices relating to the above software, please see NOTICE.TXT and EULA.rtf in the SQL Change Automation application folder.

Redgate SQL Prompt 9.5.15.11225 Write, format, and refactor SQL effortlessly

SQL Server Data Tools 16.0.61908.27190 Microsoft SQL Server Data Tools

SQL Server Reporting Services 15.0.1484.0 Microsoft SQL Server Reporting Services Designers Version 15.0.1484.0

ToolWindowHostedEditor 1.0 Hosting json editor into a tool window

TypeScript Tools 16.0.10821.2002 TypeScript Tools for Microsoft Visual Studio

Visual Basic Tools 3.3.1-beta3-19461-02+2fd12c210e22f7d6245805c60340f6a34af6875b Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Visual F# Tools 10.4 for F# 4.6 16.3.0-beta.19455.1+0422ff293bb2cc722fe5021b85ef50378a9af823 Microsoft Visual F# Tools 10.4 for F# 4.6

Visual Studio Code Debug Adapter Host Package 1.0 Interop layer for hosting Visual Studio Code debug adapters in Visual Studio

Visual Studio Tools for Containers 1.0 Visual Studio Tools for Containers

Visual Studio Tools for Kubernetes 1.0 Visual Studio Tools for Kubernetes

VisualStudio.Mac 1.0 Mac Extension for Visual Studio

Xamarin 16.3.0.274 (d16-3@06531f8) Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android.

Xamarin Designer 16.3.0.230 (remotes/origin/d16-3-xcode11@bbe518670) Visual Studio extension to enable Xamarin Designer tools in Visual Studio.

Xamarin Templates 16.3.565 (27e9746) Templates for building iOS, Android, and Windows apps with Xamarin and Xamarin.Forms.

Xamarin.Android SDK 10.0.0.43 (d16-3/8af1ca8) Xamarin.Android Reference Assemblies and MSBuild support. Mono: mono/mono/2019-06@7af64d1ebe9 Java.Interop: xamarin/java.interop/d16-3@5836f58 LibZipSharp: grendello/LibZipSharp/d16-3@71f4a94 LibZip: nih-at/libzip/rel-1-5-1@b95cf3f ProGuard: xamarin/proguard/master@905836d SQLite: xamarin/sqlite/3.27.1@8212a2d Xamarin.Android Tools: xamarin/xamarin-android-tools/d16-3@cb41333

Xamarin.iOS and Xamarin.Mac SDK 13.2.0.42 (5e8a208) Xamarin.iOS and Xamarin.Mac Reference Assemblies and MSBuild support.

mandel-macaque commented 4 years ago

@mtanml thanks, that is the correct xamarin.ios for xcode11, we will try to reproduce it in the xamarin-ios side to try and get to the bottom of the issue.

zachgreencbt commented 4 years ago

Hello,

Can you please provide the full information of your xamarin.iOS installation, would be good to know if this is happening with a package that support xcode11 or with an older one.

The easiest way to get exact version information:

On Visual Studio for Mac: "Visual Studio" menu, "About Visual Studio" item, "Show Details" button.

On Visual Studio for Windows: "Help menu", "About Microsoft Visual Studio" item.

Then copy/paste the version information (you can use the "Copy Information" button).

The Xcode version information will also be helpful since we have had several releases from Apple. (GM, GM2 or Xcode11 final).

Microsoft Visual Studio Professional 2019 Version 16.3.0 VisualStudio.16.Release/16.3.0+29318.209 Microsoft .NET Framework Version 4.8.03752

Installed Version: Professional

Visual C++ 2019 00435-20150-13783-AA224 Microsoft Visual C++ 2019

ADL Tools Service Provider 1.0 This package contains services used by Data Lake tools

Application Insights Tools for Visual Studio Package 9.1.00913.1 Application Insights Tools for Visual Studio

ASP.NET and Web Tools 2019 16.3.282.33872 ASP.NET and Web Tools 2019

ASP.NET Web Frameworks and Tools 2019 16.3.282.33872 For additional information, visit https://www.asp.net/

Azure App Service Tools v3.0.0 16.3.282.33872 Azure App Service Tools v3.0.0

Azure Data Lake Node 1.0 This package contains the Data Lake integration nodes for Server Explorer.

Azure Data Lake Tools for Visual Studio 2.3.9000.0 Microsoft Azure Data Lake Tools for Visual Studio

Azure Functions and Web Jobs Tools 16.3.282.33872 Azure Functions and Web Jobs Tools

Azure Stream Analytics Tools for Visual Studio 2.3.9000.0 Microsoft Azure Stream Analytics Tools for Visual Studio

C# Tools 3.3.1-beta3-19461-02+2fd12c210e22f7d6245805c60340f6a34af6875b C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Common Azure Tools 1.10 Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

Extensibility Message Bus 1.2.0 (d16-2@8b56e20) Provides common messaging-based MEF services for loosely coupled Visual Studio extension components communication and integration.

Fabric.DiagnosticEvents 1.0 Fabric Diagnostic Events

GitFlow.VS.Extension 1.0 Visual Studio extension that integrates GitFlow

IntelliCode Extension 1.0 IntelliCode Visual Studio Extension Detailed Info

Microsoft Azure HDInsight Azure Node 2.3.9000.0 HDInsight Node under Azure Node

Microsoft Azure Hive Query Language Service 2.3.9000.0 Language service for Hive query

Microsoft Azure Service Fabric Tools for Visual Studio 16.0 Microsoft Azure Service Fabric Tools for Visual Studio

Microsoft Azure Stream Analytics Language Service 2.3.9000.0 Language service for Azure Stream Analytics

Microsoft Azure Stream Analytics Node 1.0 Azure Stream Analytics Node under Azure Node

Microsoft Azure Tools 2.9 Microsoft Azure Tools for Microsoft Visual Studio 0x10 - v2.9.20816.1

Microsoft Continuous Delivery Tools for Visual Studio 0.4 Simplifying the configuration of Azure DevOps pipelines from within the Visual Studio IDE.

Microsoft JVM Debugger 1.0 Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines

Microsoft Library Manager 2.0.83+gbc8a4b23ec Install client-side libraries easily to any web project

Microsoft MI-Based Debugger 1.0 Provides support for connecting Visual Studio to MI compatible debuggers

Microsoft Visual C++ Wizards 1.0 Microsoft Visual C++ Wizards

Microsoft Visual Studio Tools for Containers 1.1 Develop, run, validate your ASP.NET Core applications in the target environment. F5 your application directly into a container with debugging, or CTRL + F5 to edit & refresh your app without having to rebuild the container.

Microsoft Visual Studio VC Package 1.0 Microsoft Visual Studio VC Package