AzureAD / microsoft-authentication-library-for-dotnet

Microsoft Authentication Library (MSAL) for .NET
https://aka.ms/msal-net
MIT License
1.39k stars 341 forks source link

[Feature Request] Change the default Prompt #2086

Open bgavrilMS opened 4 years ago

bgavrilMS commented 4 years ago

Which Version of MSAL are you using ? 4.x

What authentication flow has the issue?

Expected behavior If user does not specify a prompt, we should probably not send any prompt and let AAD handle things

Actual behavior We send "Select_account"

jennyf19 commented 4 years ago

@bgavrilMS why not just use noPrompt, which we already have? Is there a customer ask for this? I would think if they don't specify, then we do don't send a prompt, instead of doing "selectAccount".

bgavrilMS commented 4 years ago

@jennyf19 - I agree, but it's a bit of a breaking change.

Today, if developer does not specify a prompt, we use "select_account". I think we should not send any value, as you say.

Kusto Explorer has spent a lot of time trying to get this to work and have eventually found that "no_prompt" is a better option than "Select_account"

jennyf19 commented 4 years ago

@bgavrilMS B2C would also prefer this as well.

@jmprieur thoughts on this, as far as the customer perspective?

henrik-me commented 3 years ago

We should default to not sending any prompt value, I believe that is the latest recommendation from ests

jmprieur commented 3 years ago

yes, I agree. "no prompt" provides the best experience and does a select_account when needed. That's what we should use. I'm not even sure that this would break anything (but we'd have to test a bit)

bgavrilMS commented 3 years ago

Ok, I added this on the 4.21 release cycle.