search

AzureAD / microsoft-authentication-library-for-dotnet

Microsoft Authentication Library (MSAL) for .NET
https://aka.ms/msal-net
MIT License
1.4k stars 341 forks source link

[Feature Request] Modernize TFM support in MSAL #3864

Open bgavrilMS opened 1 year ago

bgavrilMS commented 1 year ago
pmaytak commented 1 year ago

Do you mean Net Core 2.1?

bgavrilMS commented 1 year ago

No. I mean netcoreapp 3.1 - from the MSAL.Desktop projects etc. I am not sure if we can remove netcoreapp2.1 from MSAL and rely on the netstandard tfm?

TaviTruman commented 1 year ago

2>C:\Program Files\dotnet\sdk\7.0.101\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(1027,5): error NETSDK1149: Microsoft.Identity.Client.Desktop.dll cannot be referenced because it uses built-in support for WinRT, which is no longer supported in .NET 5 and higher. An updated version of the component supporting .NET 5 is needed. For more information, see https://aka.ms/netsdk1149 Need to remove netcore3.2 support because it blocks usage of the Windows-Toolkit-Graph-Controls in WPF that target .NET 7

pmaytak commented 1 year ago

@TaviTruman For Net 7, your app needs to target at least net7.0-windows10.0.17763.0 and not reference Microsoft.Identity.Client.Desktop. It needs to be referenced only when targeting Net Framework or Net Core.