search

AzureAD / microsoft-authentication-library-for-dotnet

Microsoft Authentication Library (MSAL) for .NET
https://aka.ms/msal-net
MIT License
1.37k stars 338 forks source link

Send x-app-name and x-app-ver to query URLs #978

Closed jmprieur closed 5 years ago

jmprieur commented 5 years ago

Is your feature request related to a problem? Please describe. See add client app name and version to authorization and token requests for why and what.

What to do?

  1. In the ApplicationOptions class, add two string properties;

    • ClientName
    • ClientVersion
    • Obsolete the Component property (which was combining ClientName and Version

  2. If the developer does not provide the ClientName and ClientVersion, these are computed with values from the OS. In the case of .NET we can probably use the Assembly attributes.

  3. Append the client name and version to the following parameters when making authorization and token requests:

    • x-app-name
    • x-app-ver

.WithApplicationInformation(string clientName, string clientVersion)

MarkZuber commented 5 years ago

https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/pull/1044

jennyf19 commented 5 years ago

included in msal 3.0.3-preview