search

AzureAD / microsoft-authentication-library-for-java

Microsoft Authentication Library (MSAL) for Java http://aka.ms/aadv2
MIT License
284 stars 142 forks source link

Re-add Lombok step when packaging source files #703

Closed Avery-Dunn closed 10 months ago

Avery-Dunn commented 1 year ago

As part of the test framework update (https://github.com/AzureAD/microsoft-authentication-library-for-java/pull/672), several changes were made to the pom.xml file

One of the changes was to remove a seemingly unnecessary line related to Lombok from the <build> section: <sourceDirectory>${project.build.directory}/delombok</sourceDirectory>

With this line the -sources,jar we upload to Maven contained versions of the source files generated by Lombok, and without it the -sources,jar contains the versions of the files found here on Github. Although this difference doesn't affect the compiled code in the msal4j-x.y.z.jar that Maven would use as a dependency, it can affect any customer who may want to build the msal4j package from *-sources,jar, as they would need to also use Lombok to match what we put in the msal4j-x.y.z.jar

Avery-Dunn commented 10 months ago

Fixed as of the 1.14.0 release