search

AzureAD / microsoft-authentication-library-for-java

Microsoft Authentication Library (MSAL) for Java http://aka.ms/aadv2
MIT License
282 stars 137 forks source link

Correct IMDS_ENDPOINT #761

Closed joerattazzi-microsoft closed 7 months ago

joerattazzi-microsoft commented 7 months ago

Correcting the IDMS_ENDPOINT to adhere to the documentation: https://learn.microsoft.com/en-us/azure/virtual-machines/instance-metadata-service

bgavrilMS commented 7 months ago

Seems to be inline with MSAL.NET implementation https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/blob/main/src/client/Microsoft.Identity.Client/Instance/Region/RegionManager.cs#L35

joerattazzi-microsoft commented 7 months ago

@bgavrilMS - I couldn't find the ADO corresponding pipeline, but MSAL Java CI Build doesn't look like it's going to complete. Running the integration tests locally, they're hanging when trying to get a secret from Keyvault (via the LabAPI). Any chance you know how to fix that?

bgavrilMS commented 7 months ago

@joerattazzi-microsoft - only our CI and the MSAL team have access to those secrets, so you can't run the integration tests locally as a contributor (not that they protect something important, it's just an empty test tenant, but it'd be a hassle to make it all public).

The CI build won't run integration tests from forks also as a security measure. @Avery-Dunn will know how to unblock this.

bgavrilMS commented 7 months ago

Btw if you plan to make more contributions to MSAL 4j, I'm happy to add you as contributor so you don't have to deal with fork repos.

joerattazzi-microsoft commented 7 months ago

Btw if you plan to make more contributions to MSAL 4j, I'm happy to add you as contributor so you don't have to deal with fork repos.

This would probably help if possible, thanks! I can also reopen this PR with an in-repo branch with that access, to enable the checks.

bgavrilMS commented 7 months ago

Btw if you plan to make more contributions to MSAL 4j, I'm happy to add you as contributor so you don't have to deal with fork repos.

This would probably help if possible, thanks! I can also reopen this PR with an in-repo branch with that access, to enable the checks.

Done.

joerattazzi-microsoft commented 7 months ago

Thanks @bgavrilMS . I'm confused what github's doing with this branch, so I'm closing this PR and replacing with #762: https://github.com/AzureAD/microsoft-authentication-library-for-java/pull/762