AzureAD / microsoft-authentication-library-for-java

Microsoft Authentication Library (MSAL) for Java http://aka.ms/aadv2
MIT License
285 stars 142 forks source link

[Bug] Msal Persistence extension uses old dependencies, update them and release it. #777

Closed g2vinay closed 2 months ago

g2vinay commented 8 months ago

Library version used

1.2.0

Java version

JDK 17

Scenario

Other - please specify

Is this a new or an existing app?

None

Issue description and reproduction steps

Msal4j Persistence extension is using old version of msal4j dependency and other dependencies. Update it to latest use msal4j and release it. Update any other dependencies it uses to their latest version as well.

Relevant code snippets

No response

Expected behavior

No response

Identity provider

Microsoft Entra ID (Work and School accounts and Personal Microsoft accounts)

Regression

No response

Solution and workarounds

No response

bgavrilMS commented 8 months ago

@Avery-Dunn - isn't the extension released with every MSAL version? IMO we should release it in a similar fashion as the broker package (same repo, same version etc.)

Avery-Dunn commented 8 months ago

@bgavrilMS : No, the extensions package has always been in a separate repo, and looking at it now has gotten very out of date: https://github.com/AzureAD/microsoft-authentication-extensions-for-java

It was before my time on the team so I don't know the reason for it being separate. However, I think it would make sense to move it to this repo (Maven allows relocating projects) and following what we did for the broker package (though we'd need to find any docs and other references first)

Avery-Dunn commented 2 months ago

Forgot to close this at the time, but in https://github.com/AzureAD/microsoft-authentication-library-for-java/pull/807 the extensions package was moved to this repo, and a new 1.3.0 version was released to update the dependencies.