AzureAD / microsoft-authentication-library-for-java

Microsoft Authentication Library (MSAL) for Java http://aka.ms/aadv2
MIT License
280 stars 137 forks source link

Fix for supplied SSLSocketFactory being ignored #821

Closed stefanlourens closed 1 month ago

stefanlourens commented 1 month ago

It was checking if the connection is an instance of HttpURLConnection, but since HttpsURLConnection extends HttpURLConnection it's always true and the else is never executed.

https://github.com/AzureAD/microsoft-authentication-library-for-java/issues/820

Avery-Dunn commented 1 month ago

Thanks for making this! We have some specific fixes planned for our next release, so if this does not get merged in for that release then it will be part of a hotfix release immediately after.

stefanlourens commented 1 month ago

@bgavrilMS Do I need to do something to get the build to trigger to update the status?

bgavrilMS commented 1 month ago

@Avery-Dunn - any issues with merging this? I don't think it's unit testable.